Skip to content

manifestFiles could exist for direct but be none. fixed the check#96

Merged
Douglas (dacoburn) merged 1 commit intomainfrom
doug/another-fix-for-none-manifest
Jun 30, 2025
Merged

manifestFiles could exist for direct but be none. fixed the check#96
Douglas (dacoburn) merged 1 commit intomainfrom
doug/another-fix-for-none-manifest

Conversation

@dacoburn
Copy link
Copy Markdown
Contributor

Root Cause

Direct dependency manifestFiles could still be None breaking iteration

Fix

Correctly returned if attribute didn't exist OR was None

Public Changelog

N/A

@dacoburn Douglas (dacoburn) requested a review from a team as a code owner June 30, 2025 16:28
@dacoburn Douglas (dacoburn) requested review from Philipp Burckhardt (Planeshifter) and Chris Bailey (ammkrn) and removed request for a team June 30, 2025 16:28
@github-actions
Copy link
Copy Markdown

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.1.17.dev1

Docker image: socketdev/cli:pr-96

@dacoburn Douglas (dacoburn) merged commit 04b4420 into main Jun 30, 2025
6 checks passed
@dacoburn Douglas (dacoburn) deleted the doug/another-fix-for-none-manifest branch June 30, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants